Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rockpi-S: enable automatic u-boot flashing upon package install #7750

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

igorpecovnik
Copy link
Member

Description

It seems we need to update uboot alongside kernel, or board fails to boot. As reported on forums.

How Has This Been Tested?

  • Test B

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from brentr as a code owner January 26, 2025 08:00
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jan 26, 2025
@igorpecovnik igorpecovnik merged commit cafe0ff into main Jan 26, 2025
10 checks passed
@igorpecovnik igorpecovnik deleted the rockpi-s branch January 26, 2025 08:20
@igorpecovnik
Copy link
Member Author

@brentr images has been updated and packages pushed to repo. Need some time to all get in sync ,but its ready. I haven't tested but it looks like it should work.

@brentr
Copy link
Collaborator

brentr commented Feb 4, 2025

I verified that the latest current image for RockPI-S
Armbian_24.11.4_Rockpi-s_bookworm_current_6.12.11_minimal.img.xz

incorporates the updated U-Boot required by the 6.12 kernel.
However, since it already has the 6.12 kernel, I was not able to test whether or not upgrading from an older one to this would automatically update U-Boot as well.

I noticed that, in /etc/armbian-release,
FORCE_UBOOT_UPDATE
is still defined as the empty string.

Does it default to "yes" now?

Also, wireless was not detected on the initial log in.
Internet connection was not detected.

Connect via wireless? [Y/n] Y

Wireless connection was not detected.

Internet connection was not detected.

Connect via wireless? [Y/n] Y

Wireless connection was not detected.

There was no problem connecting to wireless after apt install network-manager.
There was a core file in the root directory.
I repeated this test 3 times. Behaved the same each time.

Would you like the core file?

@brentr
Copy link
Collaborator

brentr commented Feb 4, 2025

I had a look at the commit... Well, that was easy :-)
So, does this effectively cause
FORCE_UBOOT_UPDATE
to default to "yes" to ensure that u-boot is reinstalled on subsequent kernel upgrades to the system isn't left in an unbootable state?
(caused by the kernel upgrade requiring an updated u-boot)

I'll submit a PR to add FORCE_UBOOT_UPDATE=yes to RockS0 as well.

@igorpecovnik
Copy link
Member Author

There was no problem connecting to wireless after apt install network-manager.

1st boot setup is about to be replaced with armbian-config functions, so we don't double this code. But I also don't know if that method already works: https://docs.armbian.com/User-Guide_Armbian-Config/Network/

Idea is that this works without network-manager.

o default to "yes" to ensure that u-boot is reinstalled on subsequent kernel upgrades

Yes, more precisely, when u-boot / all package(s) is/are upgraded.

I'll submit a PR to add FORCE_UBOOT_UPDATE=yes to RockS0 as well.

OK

@igorpecovnik
Copy link
Member Author

Would you like the core file?

No, I already found and fix the problem. But in armbian-config, so this 1st boot connectivity will remain broken until we don't replace it. It is WIP but I doubt it will be ready for 02/2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

2 participants