Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test system with additional test case functionality #370

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 13, 2025

Description

  • test script can have function testcase which includes a script that needs to be executed
  • CONDITION and PREINSTALL variables are deprecated as general condition is that function testcase completes
  • unit tests are now run on latest Armbian images

Implementation Details

Test config example:

ENABLED=true
RELEASE="bookworm:noble"

function testcase {
        ./bin/armbian-config --api module_cockpit install
        [ -f /usr/bin/cockpit-bridge ]
}

Documentation Summary

Updated Readme.md in the tests folder.

Testing Procedure

  • All test cases has been moved to new system

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have ensured that my changes do not introduce new warnings or errors
  • No new external dependencies are included
  • Changes have been tested and verified
  • I have included necessary metadata in the code, including associative arrays

@github-actions github-actions bot added size/small PR with less then 50 lines GitHub Actions GitHub Actions code labels Jan 13, 2025
@igorpecovnik igorpecovnik force-pushed the unit branch 5 times, most recently from 3134a25 to 94f0452 Compare January 13, 2025 16:21
@github-actions github-actions bot added size/medium PR with more then 50 and less then 250 lines and removed size/small PR with less then 50 lines labels Jan 13, 2025
@igorpecovnik igorpecovnik force-pushed the unit branch 9 times, most recently from ce9c094 to 34d06a2 Compare January 14, 2025 09:13
@github-actions github-actions bot added GitHub GitHub-related changes like labels, templates, ... Unit Tests labels Jan 14, 2025
@igorpecovnik igorpecovnik force-pushed the unit branch 10 times, most recently from d962531 to 1928603 Compare January 14, 2025 09:35
@igorpecovnik igorpecovnik force-pushed the unit branch 16 times, most recently from 4ef57ca to cdcafe4 Compare January 15, 2025 15:32
@Tearran
Copy link
Member

Tearran commented Jan 15, 2025

This is great.

@igorpecovnik igorpecovnik force-pushed the unit branch 6 times, most recently from 6cccf8f to fe1609e Compare January 19, 2025 14:15
@igorpecovnik igorpecovnik changed the title Improve unit test system Improve unit test system with additional test case functionality Jan 19, 2025
@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Jan 19, 2025
@igorpecovnik igorpecovnik merged commit 6167d54 into main Jan 19, 2025
24 checks passed
@igorpecovnik igorpecovnik deleted the unit branch January 19, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Documentation Documentation changes or additions GitHub Actions GitHub Actions code GitHub GitHub-related changes like labels, templates, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants