client: set fiat auth user for delete pipelines request #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all request going via wrapper `request` but delete function deleting stale pipelines directly and was missing header for fiat user
its-aqeel
changed the title
jasonmcintosh
approved these changes
Feb 26, 2024
| @@ -280,6 +280,10 @@ func (c *Client) Delete(url, traceparent string) error { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| if c.FiatUser != "" { | |||
| request.Header.Set(SpinFiatUserHeader, c.FiatUser) | |||
| request.Header.Set(SpinFiatAccountHeader, c.FiatUser) | |||
There was a problem hiding this comment.
I've temporarily approved but TECHNICALLY account header isn't the right spot for the fiat user. SHouldn't set that JUST the user header.
There was a problem hiding this comment.
ALSO be kinda nice if a test on this...
There was a problem hiding this comment.
tested in private environment and it's working fine
|
Closing in favor of another PR which adds this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
all request going via wrapper
requestbut delete function deleting stale pipelines directly and was missing header for fiat userPR Checklist
Make sure the following checklist items are done before merging this PR.
CHANGELOG.mdin the## Unreleasedsection (instructions here)