0.2.4 The "Speedy" Update #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored `cfbd_json_py.games.get_cfbd_player_game_stats()`, `cfbd_json_py.plays.get_cfbd_pbp_play_types()`, and `cfbd_json_py.players.get_cfbd_player_season_stats()` to use a significantly faster process to parse player stats. - Changed `print()` statements into `logging.info()` statements for `cfbd_json_py.games.get_cfbd_player_advanced_game_stats()` - For `cfbd_json_py.metrics.get_cfbd_predicted_ppa_from_down_distance()`, a `logging.warn()` call is now a `logging.warning()` call due to a pending deprecation of `logging.warn()`. - Fixed an issue found in `cfbd_json_py.players.get_cfbd_pbp_stats()` where the function would warn the user about an issue that the user should not have triggered. - Removed `tqdm` integration with `cfbd_json_py.plays.get_cfbd_pbp_play_types()`, `cfbd_json_py.rankings.get_cfbd_poll rankings()`. - Updated the package version to `0.2.4`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cfbd_json_py.games.get_cfbd_player_game_stats(),cfbd_json_py.plays.get_cfbd_pbp_play_types(), andcfbd_json_py.players.get_cfbd_player_season_stats()to use a significantly faster process to parse player stats.print()statements intologging.info()statements forcfbd_json_py.games.get_cfbd_player_advanced_game_stats()cfbd_json_py.metrics.get_cfbd_predicted_ppa_from_down_distance(), alogging.warn()call is now alogging.warning()call due to a pending deprecation oflogging.warn().cfbd_json_py.players.get_cfbd_pbp_stats()where the function would warn the user about an issue that the user should not have triggered.tqdmintegration withcfbd_json_py.plays.get_cfbd_pbp_play_types(),cfbd_json_py.rankings.get_cfbd_poll rankings().0.2.4.