Fix building with NO_LOGGING enabled in non-shipping #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-jamin
reviewed
Feb 8, 2025
arnaud-jamin
requested changes
Feb 8, 2025
|
Will fix tomorrow! |
|
Just to update, I'll be fixing it Monday instead, since I'll have access to my work PC and it's easier than at home! |
|
I updated the PR, the sample now compiles in Development, Test and Shipping configurations! Like I mentioned first, it's probably not the optimal way to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to build in a configuration with
NO_LOGGINGthat isn't Shipping (e.g. Test), there's a lot of errors related to log categories.Following the examples in UE's
ProfilingDebugging/TraceScreenshot.hfile, I aliased the correct type depending on whether logging is enabled. I also corrected some macros that broke under the same circumstances.Some parts of Cog could probably be completely disabled if logging is disabled, but I don't know enough about it yet to do that. This PR is only meant to fix compile errors, not optimally disable components.