Time64 #583
Open
Time64 #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Functionally tested in my repository on linux-x86_64 and amiga-m68k (for backwards compatibility). Build tested on linux-x86_64 and pc-x86_64 in this repository. |
added 8 commits
December 26, 2022 09:09
Introduction on struct timeval32 as first step of migration towards 64-bit time. intuition/preferences -> 32-bit is enough to store these values prefs/input.h -> 32-bit is enough to store these values InputEvent.ie_TimeStamp -> today this contains absolute time, but the requirement is only to monotonically grow, so a relative time is enough if used consistently. GetSysTime32/CurrentTime will do a rollover and will continue returning growing values
64-bit time will have separate commands and separate timerequest structure. This matches how 64-bit was introduced in trackdisk commands (although there it was possible to use the same structure which is not possible in this case).
|
FYI, the Codacy warnings are invalid in this case. We are setting fields of the request and passing the request to DoIO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal of implementation of future 64-bit time support. What the changes do now is to freeze certain elements on 32-bit "forever" - essentially places where relative time is used and 32-bits is enough as well as document how the implementation can be done in future in a way that no longer breaks compatibility.
Note: side effect of these structure changes is that structure copying no longer works in some cases even though structures have same fields. This means field by field copying is needed.