C library #604
Open
C library #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 4, 2023 07:13
This makes fpos_t consistent with off_t and other file system types. fpos_t will now be 64-bit on 64-bit system and on 32-bit systems when _FILE_OFFSET_BITS=64. In other case it will be 32-bit wide. This sizing behavior was also validated with GNU Linux.
This makes ino_t consistent with other file system types. ino_t will now be 64-bit on 64-bit system and on 32-bit systems when _FILE_OFFSET_BITS=64. In other case it will be 32-bit wide. This sizing behavior was also validated with GNU Linux.
This matches behavior of other function defined as static inline in headers and allows code re-implementing these functions to compile
|
Thanks deadwood - I may need to review the fpos/ino stuff to make sure its the correct thing (afaik this should be decided by the use of flags at compile time), but its a while since I touched the posix side so need to refresh a bit on this stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change to sizing of types to complete 64-bit interface. See each commit for explanation.
Build-tested under linux-x86_64