update plugin for harmonic

[Apurv354]

No description provided.

[fabid]

this change is to support harmonic, right? would it work for all of humble/iron/rolling as far as you know?

Also I think you may need to update the tests, as the industrial CI seems ro be failing with errors related to the changes

[Apurv354]

this change is to support harmonic, right? would it work for all of humble/iron/rolling as far as you know?

Also I think you may need to update the tests, as the industrial CI seems ro be failing with errors related to the changes

These changes should work with iron.

[fabid]

Thank you for the tests fixes

These changes should work with iron.

My point here is that we may want to use the gazebo version for the branch name, rather than the ROS version.

[Apurv354]

Thank you for the tests fixes

These changes should work with iron.

My point here is that we may want to use the gazebo version for the branch name, rather than the ROS version.

gz plugins are supported from iron ros version. If you have humble then you cannot run these plugins link

[fabid]

@Apurv354 To confirm, is it ok to not update this line:

sciurus17_description/package.xml

Line 16 in de97ce7

<depend>ign_ros2_control</depend>

?

I think you had to build it from source so that it works?

Maybe a note in the README that the ign_ros2_control repo needs to be pulled on a specific branch

[Apurv354]

@Apurv354 To confirm, is it ok to not update this line:

sciurus17_description/package.xml

Line 16 in de97ce7

<depend>ign_ros2_control</depend>

?
I think you had to build it from source so that it works?

Maybe a note in the README that the ign_ros2_control repo needs to be pulled on a specific branch

That is correct we need to build in iron branch.
I will update the readme.

[fabid]

@Apurv354 we should probably move forward with this pull request. the changes seem necessary

But one thing that surprises me is that I have succesfully run with iron/harmonic on my machine using the humble-devel branch, without those changes.