Search: Fixes the spacing issue between suggested artworks (AIC-633) #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 20, 2018 14:23
…sCell view holders
Cliabhach
suggested changes
Nov 20, 2018
| @@ -85,7 +85,8 @@ class SearchTourCellViewModel(val articTour: ArticTour) : SearchBaseListItemView | |||
| /** | |||
| * ViewModel for displaying the circular artwork image under "On the map" section. | |||
| */ | |||
| class SearchCircularCellViewModel(val artwork: ArticObject?) : SearchBaseCellViewModel() { | |||
| class SearchCircularCellViewModel(val artwork: ArticObject?, | |||
| override val order: Int = -1) : SearchBaseCellViewModel(), OrderedCellViewModel { | |||
There was a problem hiding this comment.
I think we can remove the default value for order here. That way the compiler will error out if we forget to include a number.
Cliabhach
approved these changes
Nov 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause behind this issue was the logic we used to get column number for suggested artworks. That logic was based on the position of the
on the mapcell.This logic can go wrong when suggested artwork cells are recycled before that
on the mapcell. So the proposed solution is to not useon the mapcell at all. Now I pass the order of the cells when they are constructed and then use it to calculate the column index.