small enhancements #250

VincentAuriau · 2025-07-18T12:19:56Z

No description provided.

gemini-code-assist

Summary of Changes

Hello @VincentAuriau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces several small but impactful enhancements across the codebase. It refines the alea_carta model's implementation by improving code clarity and optimizing certain TensorFlow operations. Concurrently, it modernizes the project's dependency management by adopting PEP 621 standards in pyproject.toml and updating the Poetry lock file, ensuring a more robust and standardized build environment. Additionally, it sets up the example notebook to run on CPU by default.

Highlights

Code Refinements in alea_carta.py: Improved docstrings for clarity, removed explicit GPU detection logic, and optimized array creation for efficiency.
Basket Utility Calculation Optimization: Replaced tf.ragged operations with a more direct tf.gather call in compute_batch_utility for potentially better performance and simpler tensor handling.
Project Metadata Standardization: Migrated core and optional dependency definitions, as well as project URLs, to the PEP 621 standard within pyproject.toml. This enhances project configurability and maintainability.
Dependency Management Update: The Poetry version was upgraded, and dependency groups and markers were refined in poetry.lock to ensure a more consistent and robust development environment across different Python versions and platforms.
Notebook Environment Control: Added an explicit setting to force CPU execution for the alea_carta.ipynb notebook, preventing unintended GPU usage.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces several small enhancements. It refactors the pyproject.toml to align with modern packaging standards (PEP 621), which is a great improvement. It also includes performance optimizations in alea_carta.py by replacing ragged tensor operations with a more efficient dense tensor approach. Docstrings have been improved for clarity, and a notebook has been updated for better reproducibility.

I've left a couple of comments regarding code maintainability: one about removing a large block of commented-out code, and another about a potentially redundant section in pyproject.toml. Overall, these are positive changes that improve the quality of the codebase.

gemini-code-assist · 2025-07-18T12:22:00Z

pyproject.toml

+[tool.setuptools]
+packages = ["choice_learn"]
+


This [tool.setuptools] section seems redundant given that the build-backend is poetry.core.masonry.api. Poetry should automatically discover the choice_learn package, and this section might be confusing as it will not be used by Poetry. If it's for a specific reason, a comment explaining it would be helpful. Otherwise, it could be removed.

for more information, see https://pre-commit.ci

github-actions · 2025-07-18T12:26:01Z

Coverage Report for Python 3.10

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	48	0	100%
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	273	244	11%	79–157, 173–240, 251–262, 299–381, 417–441, 490–544, 582–616, 662–747, 788–801, 825–964, 998–1050, 1060–1082, 1099–1153
dataset.py	137	12	91%	71–74, 362, 369, 523–528, 560–567
preprocessing.py	94	78	17%	43–45, 128–364
shopper.py	358	27	92%	165, 194, 343, 363, 378, 381, 395, 684–688, 781–785, 883–887, 1218, 1297, 1335–1336, 1440–1441, 1517–1518
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	647	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	239	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 577
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	393	4	99%	39, 154–155, 715
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	257	12	95%	144, 186, 283, 302, 342, 349, 378, 397, 428–429, 438–439
baseline_models.py	49	0	100%
conditional_logit.py	236	21	91%	46, 49, 51, 82, 85, 88–92, 95–99, 133, 298, 335, 392, 467–473, 598, 632, 739, 743
halo_mnl.py	124	2	98%	186, 374
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	238	238	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
TOTAL	5090	953	81%

Tests	Skipped	Failures	Errors	Time
165	0 💤	0 ❌	0 🔥	4m 57s ⏱️

github-actions · 2025-07-18T12:26:04Z

Coverage Report for Python 3.11

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	48	0	100%
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	273	244	11%	79–157, 173–240, 251–262, 299–381, 417–441, 490–544, 582–616, 662–747, 788–801, 825–964, 998–1050, 1060–1082, 1099–1153
dataset.py	137	12	91%	71–74, 362, 369, 523–528, 560–567
preprocessing.py	94	78	17%	43–45, 128–364
shopper.py	358	27	92%	165, 194, 343, 363, 378, 381, 395, 684–688, 781–785, 883–887, 1218, 1297, 1335–1336, 1440–1441, 1517–1518
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	647	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	239	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 577
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	393	4	99%	39, 154–155, 715
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	257	12	95%	144, 186, 283, 302, 342, 349, 378, 397, 428–429, 438–439
baseline_models.py	49	0	100%
conditional_logit.py	236	21	91%	46, 49, 51, 82, 85, 88–92, 95–99, 133, 298, 335, 392, 467–473, 598, 632, 739, 743
halo_mnl.py	124	2	98%	186, 374
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	238	238	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
TOTAL	5090	953	81%

Tests	Skipped	Failures	Errors	Time
165	0 💤	0 ❌	0 🔥	5m 1s ⏱️

github-actions · 2025-07-18T12:26:05Z

Coverage Report for Python 3.9

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	48	0	100%
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	271	242	11%	79–157, 173–240, 251–262, 299–381, 417–441, 490–544, 582–616, 662–747, 788–801, 825–964, 998–1050, 1060–1082, 1099–1153
dataset.py	137	12	91%	71–74, 362, 369, 523–528, 560–567
preprocessing.py	94	78	17%	43–45, 128–364
shopper.py	358	27	92%	165, 194, 343, 363, 378, 381, 395, 684–688, 781–785, 883–887, 1218, 1297, 1335–1336, 1440–1441, 1517–1518
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	647	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	239	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 577
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	393	5	99%	43–44, 154–155, 715
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	257	12	95%	144, 186, 283, 302, 342, 349, 378, 397, 428–429, 438–439
baseline_models.py	49	0	100%
conditional_logit.py	236	21	91%	46, 49, 51, 82, 85, 88–92, 95–99, 133, 298, 335, 392, 467–473, 598, 632, 739, 743
halo_mnl.py	124	2	98%	186, 374
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	236	236	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
TOTAL	5086	950	81%

Tests	Skipped	Failures	Errors	Time
165	0 💤	0 ❌	0 🔥	4m 43s ⏱️

github-actions · 2025-07-18T12:26:44Z

Coverage Report for Python 3.12

File	Stmts	Miss	Cover	Missing
choice_learn
__init__.py	2	0	100%
tf_ops.py	48	0	100%
choice_learn/basket_models
__init__.py	4	0	100%
alea_carta.py	273	244	11%	79–157, 173–240, 251–262, 299–381, 417–441, 490–544, 582–616, 662–747, 788–801, 825–964, 998–1050, 1060–1082, 1099–1153
dataset.py	137	12	91%	71–74, 362, 369, 523–528, 560–567
preprocessing.py	94	78	17%	43–45, 128–364
shopper.py	358	27	92%	165, 194, 343, 363, 378, 381, 395, 684–688, 781–785, 883–887, 1218, 1297, 1335–1336, 1440–1441, 1517–1518
choice_learn/basket_models/utils
__init__.py	0	0	100%
permutation.py	22	1	95%	37
choice_learn/data
__init__.py	3	0	100%
choice_dataset.py	647	33	95%	198, 250, 283, 421, 463–464, 589, 724, 738, 840, 842, 937, 957–961, 1140, 1159–1161, 1179–1181, 1209, 1214, 1223, 1240, 1281, 1293, 1307, 1346, 1361, 1366, 1395, 1408, 1443–1444
indexer.py	239	23	90%	20, 31, 45, 60–67, 202–204, 219–230, 265, 291, 577
storage.py	161	6	96%	22, 33, 51, 56, 61, 71
store.py	72	72	0%	3–275
choice_learn/datasets
__init__.py	4	0	100%
base.py	393	4	99%	39, 154–155, 715
expedia.py	102	83	19%	37–301
tafeng.py	49	0	100%
choice_learn/datasets/data
__init__.py	0	0	100%
choice_learn/models
__init__.py	14	2	86%	15–16
base_model.py	257	12	95%	144, 186, 283, 302, 342, 349, 378, 397, 428–429, 438–439
baseline_models.py	49	0	100%
conditional_logit.py	236	21	91%	46, 49, 51, 82, 85, 88–92, 95–99, 133, 298, 335, 392, 467–473, 598, 632, 739, 743
halo_mnl.py	124	18	85%	186, 341, 360, 364–380
latent_class_base_model.py	286	39	86%	55–61, 273–279, 288, 325–330, 497–500, 605, 624, 665–701, 715, 720, 751–752, 774–775, 869–870, 974
latent_class_mnl.py	62	6	90%	257–261, 296
learning_mnl.py	67	3	96%	157, 182, 188
nested_logit.py	291	12	96%	55, 77, 160, 269, 351, 484, 530, 600, 679, 848, 900, 904
reslogit.py	132	6	95%	285, 360, 369, 374, 382, 432
rumnet.py	236	3	99%	748–751, 982
simple_mnl.py	139	6	96%	167, 275, 347, 355, 357, 359
tastenet.py	94	3	97%	142, 180, 188
choice_learn/toolbox
__init__.py	0	0	100%
assortment_optimizer.py	27	6	78%	28–30, 93–95, 160–162
gurobi_opt.py	238	238	0%	3–675
or_tools_opt.py	230	11	95%	103, 107, 296–305, 315, 319, 607, 611
TOTAL	5090	969	81%

Tests	Skipped	Failures	Errors	Time
165	0 💤	1 ❌	0 🔥	5m 43s ⏱️

VincentAuriau added 10 commits July 13, 2025 11:37

ENH: pyproject.toml follows latest format

0f74555

fix pyproject 2

ee83e46

add urls

080b3f5

moved dependencies

14a7206

changed few things

0fc4883

Merge branch 'main' into update-pyproject

eb0b682

fix

5525bcd

fix & lock

4526eb9

small enhancements

c0dee21

fix small typosé

3f7ec93

gemini-code-assist bot reviewed Jul 18, 2025

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

e16130d

for more information, see https://pre-commit.ci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

small enhancements #250

small enhancements #250

Uh oh!

VincentAuriau commented Jul 18, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

		[tool.setuptools]
		packages = ["choice_learn"]

small enhancements #250

Are you sure you want to change the base?

small enhancements #250

Uh oh!

Conversation

VincentAuriau commented Jul 18, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 18, 2025 •

edited

Loading