-
Notifications
You must be signed in to change notification settings - Fork 8
ADD: Official Citation version #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @VincentAuriau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates an official citation for a research paper related to basket choice modeling, ensuring proper attribution and referencing. Simultaneously, it expands the project's documentation by adding new entries and dedicated pages for the 'Bakery' and 'Badminton' datasets, enhancing the overall resource availability and user experience. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the official citation for the AleaCarta paper, including a new CITATION_AC.bib
file and updates to the README.md
. It also adds documentation for the Bakery and Badminton datasets. My review focuses on ensuring the accuracy of the new citation information. I've found some inconsistencies with the publication year and conference details based on the provided DOI, and have suggested corrections to ensure users can cite the work accurately.
@inproceedings{Desir2025 | ||
doi = {10.1007/978-3-032-06118-8_8}, | ||
url = {https://doi.org/10.1007/978-3-032-06118-8_8}, | ||
publisher = {Springer Nature Switzerland}, | ||
author = {Jules D{\'e}sir and Vincent Auriau and Martin Mo{\v{z}}ina and Emmanuel Malherbe}, | ||
title = {Better Capturing Interactions between Products in Retail: Revisited Negative Sampling for Basket Choice Modeling}, | ||
booktitle={Machine Learning and Knowledge Discovery in Databases. ECML PKDD 2025.}, | ||
year={2026} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several inconsistencies in the BibTeX entry. According to the provided DOI, the paper was published in 2024 for the ECML PKDD 2024 conference. The citation key, year, and booktitle should be updated to reflect the correct publication information. This will ensure users cite the work correctly.
@inproceedings{Desir2024,
doi = {10.1007/978-3-032-06118-8_8},
url = {https://doi.org/10.1007/978-3-032-06118-8_8},
publisher = {Springer Nature Switzerland},
author = {Jules D\'e'sir and Vincent Auriau and Martin Mo\'v'zina and Emmanuel Malherbe},
title = {Better Capturing Interactions between Products in Retail: Revisited Negative Sampling for Basket Choice Modeling},
booktitle={Machine Learning and Knowledge Discovery in Databases. Research Track. ECML PKDD 2024.},
year={2024}
}
doi = {10.1007/978-3-032-06118-8_8}, | ||
url = {https://doi.org/10.1007/978-3-032-06118-8_8}, | ||
publisher = {Springer Nature Switzerland}, | ||
author = {Jules D{\'e}sir and Vincent Auriau and Martin Mo{\v{z}}ina and Emmanuel Malherbe}, | ||
title = {Better Capturing Interactions between Products in Retail: Revisited Negative Sampling for Basket Choice Modeling}, | ||
booktitle={Joint European Conference on Machine Learning and Knowledge Discovery in Databases}, | ||
year={2025}, | ||
organization={Springer} | ||
booktitle={Machine Learning and Knowledge Discovery in Databases. ECML PKDD 2025.}, | ||
year={2026} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are inconsistencies in this BibTeX entry. According to the provided DOI, the paper was published in 2024 for the ECML PKDD 2024 conference. The year and booktitle should be updated to reflect the correct publication information. For consistency, you might also want to update the citation key on line 296 to Desir2024
.
doi = {10.1007/978-3-032-06118-8_8}, | |
url = {https://doi.org/10.1007/978-3-032-06118-8_8}, | |
publisher = {Springer Nature Switzerland}, | |
author = {Jules D{\'e}sir and Vincent Auriau and Martin Mo{\v{z}}ina and Emmanuel Malherbe}, | |
title = {Better Capturing Interactions between Products in Retail: Revisited Negative Sampling for Basket Choice Modeling}, | |
booktitle={Joint European Conference on Machine Learning and Knowledge Discovery in Databases}, | |
year={2025}, | |
organization={Springer} | |
booktitle={Machine Learning and Knowledge Discovery in Databases. ECML PKDD 2025.}, | |
year={2026} | |
doi = {10.1007/978-3-032-06118-8_8}, | |
url = {https://doi.org/10.1007/978-3-032-06118-8_8}, | |
publisher = {Springer Nature Switzerland}, | |
author = {Jules D\'e'sir and Vincent Auriau and Martin Mo\'v'zina and Emmanuel Malherbe}, | |
title = {Better Capturing Interactions between Products in Retail: Revisited Negative Sampling for Basket Choice Modeling}, | |
booktitle={Machine Learning and Knowledge Discovery in Databases. Research Track. ECML PKDD 2024.}, | |
year={2024} |
Coverage Report for Python 3.10
|
Coverage Report for Python 3.11
|
Coverage Report for Python 3.12
|
No description provided.