Log transfer/ingest status polling errors

artefactual-labs · Jun 26, 2023 · 1625963 · 1625963
1 parent 2498c38
commit 1625963
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/internal/workflow/activities/poll_ingest.go b/internal/workflow/activities/poll_ingest.go
@@ -7,6 +7,7 @@ import (
 
 	"github.com/cenkalti/backoff/v4"
 	cadencesdk_activity "go.uber.org/cadence/activity"
+	"go.uber.org/zap"
 
 	"github.com/artefactual-labs/enduro/internal/pipeline"
 	wferrors "github.com/artefactual-labs/enduro/internal/workflow/errors"
@@ -27,6 +28,8 @@ type PollIngestActivityParams struct {
 }
 
 func (a *PollIngestActivity) Execute(ctx context.Context, params *PollIngestActivityParams) (time.Time, error) {
+	logger := cadencesdk_activity.GetLogger(ctx)
+
 	p, err := a.manager.Pipelines.ByName(params.PipelineName)
 	if err != nil {
 		return time.Time{}, wferrors.NonRetryableError(err)
@@ -59,6 +62,10 @@ func (a *PollIngestActivity) Execute(ctx context.Context, params *PollIngestActi
 				return err
 			}
 
+			if err != nil {
+				logger.Error("Failed to look up Ingest status.", zap.Error(err))
+			}
+
 			// Retry unless the deadline was exceeded.
 			if lastRetryableError.IsZero() {
 				lastRetryableError = clock.Now()

diff --git a/internal/workflow/activities/poll_transfer.go b/internal/workflow/activities/poll_transfer.go
@@ -7,6 +7,7 @@ import (
 
 	"github.com/cenkalti/backoff/v4"
 	cadencesdk_activity "go.uber.org/cadence/activity"
+	"go.uber.org/zap"
 
 	"github.com/artefactual-labs/enduro/internal/pipeline"
 	wferrors "github.com/artefactual-labs/enduro/internal/workflow/errors"
@@ -31,6 +32,8 @@ type PollTransferActivityParams struct {
 }
 
 func (a *PollTransferActivity) Execute(ctx context.Context, params *PollTransferActivityParams) (string, error) {
+	logger := cadencesdk_activity.GetLogger(ctx)
+
 	p, err := a.manager.Pipelines.ByName(params.PipelineName)
 	if err != nil {
 		return "", wferrors.NonRetryableError(err)
@@ -64,6 +67,10 @@ func (a *PollTransferActivity) Execute(ctx context.Context, params *PollTransfer
 				return err
 			}
 
+			if err != nil {
+				logger.Error("Failed to look up Transfer status.", zap.Error(err))
+			}
+
 			// Retry unless the deadline was exceeded.
 			if lastRetryableError.IsZero() {
 				lastRetryableError = clock.Now()