Skip to content

Commit

Permalink
Disable retry policy in CleanUpActivity
Browse files Browse the repository at this point in the history
  • Loading branch information
sevein committed Sep 15, 2023
1 parent 7a21676 commit b9a9ce5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions internal/workflow/policies.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ func withActivityOptsForRequest(ctx temporalsdk_workflow.Context) temporalsdk_wo
}

// withActivityOptsForLocalAction returns a workflow context with activity
// options suited for local activities like disk operations that should not
// require a retry policy attached.
// options suited for local actions like disk operations that should not require
// a retry policy attached.
func withActivityOptsForLocalAction(ctx temporalsdk_workflow.Context) temporalsdk_workflow.Context {
return temporalsdk_workflow.WithActivityOptions(ctx, temporalsdk_workflow.ActivityOptions{
StartToCloseTimeout: time.Hour,
Expand Down
2 changes: 1 addition & 1 deletion internal/workflow/processing.go
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ func (w *ProcessingWorkflow) SessionHandler(sessCtx temporalsdk_workflow.Context
// Delete local temporary files.
defer func() {
if tinfo.Bundle.FullPathBeforeStrip != "" {
activityOpts := withActivityOptsForRequest(sessCtx)
activityOpts := withActivityOptsForLocalAction(sessCtx)
_ = temporalsdk_workflow.ExecuteActivity(activityOpts, activities.CleanUpActivityName, &activities.CleanUpActivityParams{
FullPath: tinfo.Bundle.FullPathBeforeStrip,
}).Get(activityOpts, nil)
Expand Down

0 comments on commit b9a9ce5

Please sign in to comment.