Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject duplicates #548

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Reject duplicates #548

merged 1 commit into from
Jul 19, 2023

Conversation

sevein
Copy link
Member

@sevein sevein commented Jul 7, 2023 •
edited
Loading

Fixes #545.

sevein
sevein commented Jul 12, 2023
View reviewed changes
Copy link
Member Author

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased.

@camlyall camlyall force-pushed the dev/issue-545-reject-duplicates branch from 1062fbd to 725ce4a Compare July 13, 2023 11:34
sevein
sevein commented Jul 13, 2023
View reviewed changes
Copy link
Member Author

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

internal/collection/collection.go Outdated Show resolved Hide resolved
internal/workflow/local_activities.go Outdated Show resolved Hide resolved
internal/batch/workflow.go Show resolved Hide resolved
@camlyall camlyall force-pushed the dev/issue-545-reject-duplicates branch from 0630516 to aa18c7c Compare July 18, 2023 14:58
@camlyall @sevein
Add option to reject duplicates
bebbae3 
Fixes #545.

Co-authored-by: Jesús García Crespo <[email protected]>
@sevein sevein force-pushed the dev/issue-545-reject-duplicates branch from 248aedd to bebbae3 Compare July 19, 2023 15:50
@sevein sevein marked this pull request as ready for review July 19, 2023 15:51
@sevein sevein merged commit 6ebc760 into main Jul 19, 2023
9 checks passed
@sevein sevein deleted the dev/issue-545-reject-duplicates branch July 19, 2023 16:03
@djjuhasz djjuhasz mentioned this pull request Apr 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camlyall camlyall camlyall left review comments

Assignees

@camlyall camlyall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: absence of capability to reject duplicate transfers
2 participants
@sevein @camlyall