Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable retry policy in CleanUpActivity #577

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Disable retry policy in CleanUpActivity #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/workflow/policies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ func withActivityOptsForRequest(ctx temporalsdk_workflow.Context) temporalsdk_wo
}

// withActivityOptsForLocalAction returns a workflow context with activity
// options suited for local activities like disk operations that should not
// require a retry policy attached.
// options suited for local actions like disk operations that should not require
// a retry policy attached.
func withActivityOptsForLocalAction(ctx temporalsdk_workflow.Context) temporalsdk_workflow.Context {
return temporalsdk_workflow.WithActivityOptions(ctx, temporalsdk_workflow.ActivityOptions{
StartToCloseTimeout: time.Hour,
Expand Down
2 changes: 1 addition & 1 deletion internal/workflow/processing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@
// Delete local temporary files.
defer func() {
if tinfo.Bundle.FullPathBeforeStrip != "" {
activityOpts := withActivityOptsForRequest(sessCtx)
activityOpts := withActivityOptsForLocalAction(sessCtx)

Check warning on line 484 in internal/workflow/processing.go

View check run for this annotation

Codecov / codecov/patch

internal/workflow/processing.go#L484 

Added line #L484 was not covered by tests
_ = temporalsdk_workflow.ExecuteActivity(activityOpts, activities.CleanUpActivityName, &activities.CleanUpActivityParams{
FullPath: tinfo.Bundle.FullPathBeforeStrip,
}).Get(activityOpts, nil)
Expand Down
Loading