Add Extract Activity to processing workflow #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar feedback to the one I added in artefactual-sdps/enduro#932. Everything else looks good to me, but I'd wait to hear from @sevein. |
djjuhasz
force-pushed
the
dev/add-extract-activity
branch
2 times, most recently
from
da32b8e
to
0e2486b
Compare
sevein
approved these changes
May 2, 2024
jraddaoui
requested changes
May 2, 2024
djjuhasz
force-pushed
the
dev/add-extract-activity
branch
2 times, most recently
from
3d956bd
to
69b578a
Compare
- Import the github.com/artefactual-sdps/temporal-activities/archive package - Add the `archive.ExtractActivity` to the processing workflow - Remove extract archive code from the Bundle activity - Remove the watcher service from Bundle activity dependencies and work with the downloaded package files directly
djjuhasz
force-pushed
the
dev/add-extract-activity
branch
from
69b578a
to
a9dd3df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use github.com/artefactual-sdps/temporal-activities/archive to extract archives.