-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link localhost URLs #607
Link localhost URLs #607
Conversation
djjuhasz
commented
May 1, 2024
- Update hugo
- Add angle brackets to http://localhost URLs to make them links.
731a731
to
ea05b03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions:
- Are we sure that we want to commit the node_modules dir?
- Should we also update the hugo version in https://github.com/artefactual-labs/enduro/blob/main/netlify.toml?
- What's the public folder and the package.json file in the root?
Answers below.
No, if it's not necessary. I'm not clear how the whole Hugo + Docsy + node build pipeline works, so I wasn't sure if node_modules is a build artifact or required for the docs site. It looks like it's a build artifact, so I'll just remove that commit.
Yes. I missed that, sorry.
Oohh, that's probably a result of me trying to run the hugo build using the go binary directly instead of using |
78fd744
to
23a0625
Compare
@sevein I can't figure out why the Netlify build failed, can you have a look or add me to the project? |
- Update hugo binary URL to download extended version - Rename "config.toml" to "hugo.toml" - Update hugo config values where necessary - Add a go workspace with base enduro and website modules
Add angle brackets to http://localhost URLs to make them links.
23a0625
to
0771864
Compare
I will look at it in a bit. |
0eb1786
to
e0b5edf
Compare
e0b5edf
to
7787ad2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @sevein! |