Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link localhost URLs #607

Merged
merged 4 commits into from
May 3, 2024
Merged

Link localhost URLs #607

merged 4 commits into from
May 3, 2024

Conversation

djjuhasz
Copy link
Contributor

@djjuhasz djjuhasz commented May 1, 2024

@djjuhasz djjuhasz requested a review from sevein May 1, 2024 22:01
@djjuhasz djjuhasz force-pushed the dev/link-localhost-urls branch 5 times, most recently from 731a731 to ea05b03 Compare May 1, 2024 23:22
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions:

  1. Are we sure that we want to commit the node_modules dir?
  2. Should we also update the hugo version in https://github.com/artefactual-labs/enduro/blob/main/netlify.toml?
  3. What's the public folder and the package.json file in the root?

@djjuhasz
Copy link
Contributor Author

djjuhasz commented May 2, 2024

Answers below.

A couple of questions:

1. Are we sure that we want to commit the node_modules dir?

No, if it's not necessary. I'm not clear how the whole Hugo + Docsy + node build pipeline works, so I wasn't sure if node_modules is a build artifact or required for the docs site. It looks like it's a build artifact, so I'll just remove that commit.

2. Should we also update the hugo version in https://github.com/artefactual-labs/enduro/blob/main/netlify.toml?

Yes. I missed that, sorry.

3. What's the public folder and the package.json file in the root?

Oohh, that's probably a result of me trying to run the hugo build using the go binary directly instead of using make website. I'll delete those.

@djjuhasz djjuhasz force-pushed the dev/link-localhost-urls branch 3 times, most recently from 78fd744 to 23a0625 Compare May 2, 2024 17:25
@djjuhasz
Copy link
Contributor Author

djjuhasz commented May 2, 2024

@sevein I can't figure out why the Netlify build failed, can you have a look or add me to the project?

- Update hugo binary URL to download extended version
- Rename "config.toml" to "hugo.toml"
- Update hugo config values where necessary
- Add a go workspace with base enduro and website modules
Add angle brackets to http://localhost URLs to make them links.
@sevein
Copy link
Member

sevein commented May 3, 2024

I will look at it in a bit.

@sevein sevein force-pushed the dev/link-localhost-urls branch 3 times, most recently from 0eb1786 to e0b5edf Compare May 3, 2024 08:25
Copy link
Member

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djjuhasz
Copy link
Contributor Author

djjuhasz commented May 3, 2024

Thanks @sevein!

@djjuhasz djjuhasz merged commit 0a48287 into main May 3, 2024
9 checks passed
@djjuhasz djjuhasz deleted the dev/link-localhost-urls branch May 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants