Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add has duplicate method #913

Closed
wants to merge 3 commits into from
Closed

Conversation

Diogenesoftoronto
Copy link
Contributor

@Diogenesoftoronto Diogenesoftoronto commented Apr 3, 2024

HasDuplicate is a method identical in function to the one in legacy enduro here. This is the first part in a series of PRs to close issue #851

@Diogenesoftoronto Diogenesoftoronto marked this pull request as draft April 3, 2024 21:39
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 48.62%. Comparing base (6b6cdf8) to head (8feff70).
Report is 5 commits behind head on main.

Files Patch % Lines
internal/package_/package_.go 0.00% 7 Missing ⚠️
internal/package_/goa.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #913      +/-   ##
==========================================
+ Coverage   48.13%   48.62%   +0.48%     
==========================================
  Files         103      103              
  Lines        5555     5582      +27     
==========================================
+ Hits         2674     2714      +40     
+ Misses       2637     2620      -17     
- Partials      244      248       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Diogenesoftoronto Diogenesoftoronto self-assigned this Apr 4, 2024
@Diogenesoftoronto Diogenesoftoronto marked this pull request as ready for review April 8, 2024 13:53
@jraddaoui
Copy link
Collaborator

I'll close this PR since we are now using Ent in the package service.

@jraddaoui jraddaoui closed this May 2, 2024
@djjuhasz djjuhasz deleted the dev/add-has-duplicate-method branch June 14, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants