Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navbar toggler icon (#1688) #1689

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

phalene-bytes
Copy link
Contributor

Updates navbar toggler icon from BS5 icon/class to Font Awesome icon for consistency and easier client BS5 theme customization (in sync with other navbar icons)

@phalene-bytes phalene-bytes force-pushed the dev/issue-1688-update-navbar-toggler-icon branch from b29c459 to 56e3b53 Compare October 31, 2023 17:11
@phalene-bytes phalene-bytes force-pushed the dev/issue-1688-update-navbar-toggler-icon branch from 56e3b53 to d3b3113 Compare November 1, 2023 20:43
Copy link
Contributor

@anvit anvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@phalene-bytes phalene-bytes merged commit e78c42b into qa/2.x Nov 20, 2023
3 checks passed
@anvit anvit added this to the 2.8.0 milestone Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants