Implement stage-free delivery for project deliveries. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because they are required by DDS when creating a project.
It seems this method confuses pytest too much and makes mocking impossible.
OBS: there is a lot of code repetition in there and it's probably possible to make these tests more concise by writting some helper functions in the base class, but these tests are soon going to be obsolete and are going to be removed once the new delivery endpoint is released and the old ones are decommissioned.
This is in preparation for the big clean-up
This set a project as completed in the database
matrulda
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Looks great! I left some comments for you.
Regarding skip_delivery I agree that it can be removed. When doing full integration testing / validation we want to deliver data to DDS. It is not ideal that we upload to the "production env", but since there is no "Staging" version of DDS, I don't really see how we would do it differently.
Co-authored-by: Matilda Åslin <[email protected]>
This reverts commit e7a735b. Turns out I didn't need this function in the end.
|
Nice comments! Ready for the second round of review now. Then I think it's ready for merging and testing in staging after we update snpseq_packs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problems does this PR solve?
The delivery system has been switched to DDS. This program provides an option to upload files to a specific location. This makes the staging step unnecessary. Skipping this step would both reduce delivery times and simplify the code
The delivery service supports three delivery modes: project, runfolder, and runfolder for projects. This PR introduces a new delivery route for projects (the simplest case). The goal is to test if this works as expected and to gather feedback before we apply this change to the other (more complex) delivery modes. All former delivery routes remain available.
Some design questions to think about:
As it is now, I have not implemented the
skip_deliveryoption, is this something we want to keep?Risk analysis:
How has the changes been tested?
In addition to automatic tests, has any manual testing been carried out? Unit tests and integration tests have been updated.
Reasons for careful code review
If any of the boxes below are checked, extra careful code review should be initiated.