Bio 2360 organise from config #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monikaBrandt
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Good job @b97pla! I only had minor comments and not really requesting any changes at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problems does this PR solve?
This PR combines #45 and #49, including some fixes and rewrites to merge and harmonize the code.
It implements parsing of a
.ymlconfig file, resolving glob expressions and substituting variables defined in the config and through capturing expressions in a filter regexp.It also implements the staging of source files to a separate file structure, either through copy operations or symlinking.
How has the changes been tested?
Unit tests.
Reasons for careful code review
If any of the boxes below are checked, extra careful code review should be inititated.