possible fix of issue #6

arterialist · May 25, 2018 · 8c6abc5 · 8c6abc5
1 parent 200b4b3
commit 8c6abc5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/.gitignore b/.gitignore
@@ -104,4 +104,5 @@ venv.bak/
 .mypy_cache/
 
 # project-specific
-files/storage.db
+files/storage.db
+/.idea/
diff --git a/callback/callbacks.py b/callback/callbacks.py
@@ -108,19 +108,19 @@ def new_message_callback(packet, window):
                 break
 
 
-def invalid_message_callback(reason, message, window):
-    alert_box = QMessageBox(window)
+def invalid_message_callback(reason, message):
+    alert_box = QMessageBox()
     alert_box.setWindowTitle("Invalid message received")
     alert_box.setText("Reason:\n{}".format(reason))
     alert_box.addButton("View", QMessageBox.ActionRole)
     alert_box.setStandardButtons(QMessageBox.Ok)
-    alert_box.buttonClicked.connect(lambda btn: view_button_clicked_callback(btn, message, window))
+    alert_box.buttonClicked.connect(lambda btn: view_button_clicked_callback(btn, message))
     alert_box.exec_()
 
 
-def view_button_clicked_callback(button, message, window):
+def view_button_clicked_callback(button, message):
     if button.text() == "View":
-        alert_box = QMessageBox(window)
+        alert_box = QMessageBox()
         alert_box.setWindowTitle("Message")
         alert_box.setText(message)
         alert_box.addButton("Ok", QMessageBox.YesRole)

diff --git a/main.py b/main.py
@@ -84,7 +84,7 @@ def init_ui(self):
 
         client_base.init_socket()
         client_base.new_message_callback = lambda message: new_message_callback(message, window)
-        client_base.invalid_message_callback = lambda reason, message: invalid_message_callback(reason, message, window)
+        client_base.invalid_message_callback = lambda reason, message: invalid_message_callback(reason, message)
 
     def closeEvent(self, a0: QCloseEvent):
         client_base.finish()