-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSA Hostkey, RSA Certificate, and DH Group Exchange Moduli Tests #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…continue on instead of terminating the program.
I'd love to fix the failing test, but I'm not sure how to run them locally. Any hints? |
@arthepsy ping |
@jtesta sorry for not getting back sooner. Will reply in few hours. |
@arthepsy re-ping |
@arthepsy So, uhh... hi. Its been over a year, and this hasn't been merged. Are you still interested in maintaining this project? If not, I'd be happy to take over as maintainer! |
And another year has passed 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RSA key size checking (for both stand-alone host keys AND those in certificates), as well as Diffie-Hellman group exchange modulus tests (solves issues #19 and #24). Moduli found to be less than 2,048-bits are flagged.
Example results:
Additional certificate tests can be added in the future, such as principle matching checks, and validation of time ranges. If there's interest in the obsolete "[email protected]" host key type, that can be added as well (this PR only handles the newer "[email protected]" type).
Unfortunately, I've run out of time, and can't get to fixing the mypy errors introduced. That probably isn't too hard, though, for someone familiar with mypy.