Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-add support for TypeScript 5.6 #422

Merged
merged 2 commits into from
Nov 30, 2024

Conversation

WikiRik
Copy link
Contributor

@WikiRik WikiRik commented Nov 30, 2024

Due to some unrelated changes I'm not able to update to TypeScript 5.7 yet, and while I can workaround the warnings of NPM it would be nice to not have to do this since there is no change in the package that requires TypeScript 5.7.

It could also be considered to re-add support for earlier versions. Prisma v6 even supports TypeScript 5.1; https://www.prisma.io/docs/orm/more/upgrade-guides/upgrading-versions/upgrading-to-prisma-6#minimum-supported-typescript-version

@WikiRik
Copy link
Contributor Author

WikiRik commented Nov 30, 2024

While my request might still be valid for others, I made a different workaround for the issue that was preventing me from updating. Feel free to close this PR if you do not agree with supporting multiple TypeScript versions

@arthurfiorette
Copy link
Owner

^5.6 also matches 5.7, so I just lowered it back to 5.6.

@arthurfiorette arthurfiorette merged commit bc170b0 into arthurfiorette:main Nov 30, 2024
1 check passed
@WikiRik WikiRik deleted the patch-1 branch November 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants