Change in calculating derv2. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Arthur,
I've started using this great project of yours earlier today and I've noticed it throws System.IndexOutOfRangeException in
OSPCResult.Createmethod when there are only two files to be compared.Exception ocurres on line
result.POI_Similarity = lst[lst.CalcDerv2().MaxIndex()];because
CalcDerv2()returns an empty array andMaxIndex()then returns the default -1.Also,
CalcDerv2()would throw System.OverflowException when passed an array containing less than two elements.I thought that a straightforward workaround to this would be simply not to try to calculate POI_Similarity when unable to calulate the derivation, so I've made some changes to avoid having these error messages show up. It would be great if If you could review them.
Best regards,
Antonia