New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use torch_dtype=fp16 when specified #236

Open

tmm1 wants to merge 1 commit into artidoro:main from tmm1:torch-dtype-fp16

tmm1 commented Jul 31, 2023

i noticed this while reviewing the code. when using --fp16, it still sets torch_dtype=torch.float32

is this by design, or an oversight?

is this intentionally set to a different value than compute_dtype?


          use torch_dtype=fp16 when specified

tongyx361 commented Sep 4, 2023

I think it should be a typo error, because there is another torch.float32 at the end of if-else logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet