Skip to content

Commit

Permalink
Apple set_argparse_from_dict to all arg parsers
Browse files Browse the repository at this point in the history
  • Loading branch information
lukeshingles committed Feb 16, 2024
1 parent 575e41d commit 116f39a
Show file tree
Hide file tree
Showing 37 changed files with 42 additions and 45 deletions.
2 changes: 1 addition & 1 deletion artistools/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
from artistools.misc import read_linestatfile
from artistools.misc import readnoncommentline
from artistools.misc import roman_numerals
from artistools.misc import set_argparse_from_dict
from artistools.misc import set_args_from_dict
from artistools.misc import showtimesteptimes
from artistools.misc import split_dataframe_dirbins
from artistools.misc import stripallsuffixes
Expand Down
4 changes: 2 additions & 2 deletions artistools/deposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ def main_analytical(args: argparse.Namespace | None = None, argsraw: list[str] |
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)
dfmodel, modelmeta = at.inputmodel.get_modeldata(args.modelpath, derived_cols=["mass_g", "vel_r_min_kmps"])

Expand Down Expand Up @@ -127,7 +127,7 @@ def main(args: argparse.Namespace | None = None, argsraw: list[str] | None = Non
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

# TODO: plot deposition.out file!
Expand Down
2 changes: 1 addition & 1 deletion artistools/estimators/exportmassfractions.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

modelpath: Path = Path()
Expand Down
2 changes: 1 addition & 1 deletion artistools/estimators/plotestimators.py
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
at.set_argparse_from_dict(parser, kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/gsinetwork.py
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
6 changes: 3 additions & 3 deletions artistools/inputmodel/1dslicefrom3d.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import matplotlib.pyplot as plt

from artistools import CustomArgHelpFormatter
import artistools as at


def addargs(parser: argparse.ArgumentParser) -> None:
Expand All @@ -27,11 +27,11 @@ def addargs(parser: argparse.ArgumentParser) -> None:
def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None = None, **kwargs: t.Any) -> None:
if args is None:
parser = argparse.ArgumentParser(
formatter_class=CustomArgHelpFormatter,
formatter_class=at.CustomArgHelpFormatter,
description="Covert abundances.txt and model.txt from 3D to a one dimensional slice.",
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args()

if not Path(args.outputfolder).exists():
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/botyanski2017.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

e_k = 1.2 # in units of 10^51 erg
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/describeinputmodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/from_alcar.py
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/fullymixed.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

dfmodel, t_model_init_days, _ = at.inputmodel.get_modeldata_tuple(args.inputpath, derived_cols=["mass_g"])
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/makeartismodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/maptogrid.py
Original file line number Diff line number Diff line change
Expand Up @@ -481,7 +481,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/modelfromhydro.py
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/plotdensity.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/plotinitialcomposition.py
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/recombinationenergy.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/rprocess_from_trajectory.py
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/rprocess_solar.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

dfsolarabund = pd.read_csv(
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/scalevelocity.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

dfmodel, t_model_init_days, _ = at.inputmodel.get_modeldata_tuple(args.inputfile)
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/shen2018.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

with Path(args.inputpath).open() as infile:
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/slice1dfromconein3dmodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=__doc__,
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if not args.modelpath:
Expand Down
8 changes: 3 additions & 5 deletions artistools/inputmodel/test_inputmodel.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ def clear_modelfiles() -> None:


def test_describeinputmodel() -> None:
at.inputmodel.describeinputmodel.main(argsraw=[], inputfile=modelpath, get_elemabundances=True)
at.inputmodel.describeinputmodel.main(argsraw=[], inputfile=modelpath, isotopes=True)


def test_describeinputmodel_3d() -> None:
at.inputmodel.describeinputmodel.main(argsraw=[], inputfile=modelpath_3d, get_elemabundances=True)
at.inputmodel.describeinputmodel.main(argsraw=[], inputfile=modelpath_3d, isotopes=True)


def test_get_modeldata_1d() -> None:
Expand Down Expand Up @@ -234,9 +234,7 @@ def test_makemodel() -> None:

def test_makemodel_energyfiles() -> None:
clear_modelfiles()
at.inputmodel.makeartismodel.main(
argsraw=[], modelpath=modelpath, makeenergyinputfiles=True, modeldim=1, outputpath=outputpath
)
at.inputmodel.makeartismodel.main(argsraw=[], modelpath=modelpath, makeenergyinputfiles=True, outputpath=outputpath)


def test_maketardismodel() -> None:
Expand Down
2 changes: 1 addition & 1 deletion artistools/inputmodel/to_tardis.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/lightcurve/plotlightcurve.py
Original file line number Diff line number Diff line change
Expand Up @@ -1576,7 +1576,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
at.set_argparse_from_dict(parser, kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)
if args.average_every_tenth_viewing_angle:
Expand Down
2 changes: 1 addition & 1 deletion artistools/linefluxes.py
Original file line number Diff line number Diff line change
Expand Up @@ -898,7 +898,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=(__doc__),
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if not args.modelpath:
Expand Down
2 changes: 1 addition & 1 deletion artistools/logfiles.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
formatter_class=at.CustomArgHelpFormatter, description="Plot durations from log files."
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if not args.modelpath:
Expand Down
2 changes: 1 addition & 1 deletion artistools/macroatom.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
formatter_class=at.CustomArgHelpFormatter, description="Plot ARTIS macroatom transitions."
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if Path(args.outputfile).is_dir():
Expand Down
2 changes: 1 addition & 1 deletion artistools/misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ def get_ionstring(
return f"{get_elsymbol(atomic_number)}{strcharge}"


def set_argparse_from_dict(parser: argparse.ArgumentParser, kwargs: dict[str, t.Any]) -> None:
def set_args_from_dict(parser: argparse.ArgumentParser, kwargs: dict[str, t.Any]) -> None:
"""Set argparse defaults from a dictionary."""
# set_defaults expects the dest of an argument. Here we allow the option strings to be used as keys
for arg in parser._actions:
Expand Down
2 changes: 1 addition & 1 deletion artistools/nltepops/plotnltepops.py
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
if args is None:
parser = argparse.ArgumentParser(description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

at.set_mpl_style()
Expand Down
2 changes: 1 addition & 1 deletion artistools/nonthermal/plotnonthermal.py
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)

addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if not args.modelpath:
Expand Down
2 changes: 1 addition & 1 deletion artistools/nonthermal/solvespencerfanocmd.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=__doc__,
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if args.plotstats:
Expand Down
2 changes: 1 addition & 1 deletion artistools/plotspherical.py
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ def main(args: argparse.Namespace | None = None, argsraw: list[str] | None = Non
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/radfield.py
Original file line number Diff line number Diff line change
Expand Up @@ -959,7 +959,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
if args is None:
parser = argparse.ArgumentParser(formatter_class=at.CustomArgHelpFormatter, description=__doc__)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

at.set_mpl_style()
Expand Down
3 changes: 1 addition & 2 deletions artistools/spectra/plotspectra.py
Original file line number Diff line number Diff line change
Expand Up @@ -1361,8 +1361,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=__doc__,
)
addargs(parser)
at.set_argparse_from_dict(parser, kwargs)

at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)
if args.average_every_tenth_viewing_angle:
Expand Down
2 changes: 1 addition & 1 deletion artistools/spectra/writespectra.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=__doc__,
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
argcomplete.autocomplete(parser)
args = parser.parse_args([] if kwargs else argsraw)

Expand Down
2 changes: 1 addition & 1 deletion artistools/transitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=__doc__,
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if Path(args.outputfile).is_dir():
Expand Down
2 changes: 1 addition & 1 deletion artistools/writecomparisondata.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def main(args: argparse.Namespace | None = None, argsraw: t.Sequence[str] | None
description=__doc__,
)
addargs(parser)
parser.set_defaults(**kwargs)
at.set_args_from_dict(parser, kwargs)
args = parser.parse_args([] if kwargs else argsraw)

if not args.modelpath:
Expand Down

0 comments on commit 116f39a

Please sign in to comment.