Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added mathrm and color to text environments inside math blocks #384

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

superle3
Copy link
Contributor

@superle3 superle3 commented Feb 1, 2025

solves #378.

Ideally I would make this a setting since there are more text environments people may want to use like \textit, \label or something else but that don't make sense as default options.
But I first want to know if that feature is alright before I work on it.

@artisticat1
Copy link
Owner

Thanks!

... \textit, \label or something else but that don't make sense as default options.

Oh, I'd have thought they make sense to add as well - why not?

@artisticat1 artisticat1 merged commit a5355f7 into artisticat1:main Feb 1, 2025
@superle3
Copy link
Contributor Author

superle3 commented Feb 1, 2025

I haven't used them, so I don't know if they make sense as default. But you also have \textcolor instead of \color which look the same or \textrm instead of \mathrm. So adding every environment seemed unnecessary.

I mostly use \text for text and \mathrm for math things like V_{\mathrm{Tot}} or \mathrm{Sinc} . Besides that I don't think I use another text environment.
\operatorname would also make sense as a default.

But can it be a setting or not?

@artisticat1
Copy link
Owner

Sure, we can make it a setting. We currently have a couple of settings for things which make better sense being hardcoded (e.g. the list of matrix environments), but are there in case a user wishes to tweak them.

But you also have \textcolor instead of \color which look the same or \textrm instead of \mathrm. So adding every environment seemed unnecessary.

I think it makes sense to add all text environments one might conceivably use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants