-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ceres::LocalParameterization to ceres::Manifold #295
Update ceres::LocalParameterization to ceres::Manifold #295
Conversation
Hi @mattalvarado, As you can see, |
@mattalvarado I've adressed my own comments above and opened a PR against your own fork to let you update your PR if it all looks fine to you. See the PR here. |
Support Ceres both pre/post 2.2
Thanks @artivis! Your PR is merged |
Signed-off-by: artivis <[email protected]>
macos-11 runners have been deprecated
Thanks a lot @mattalvarado for the great contribution! |
Ceres v2.2.0 has deprecated ceres::LocalParametrization in favor of ceres::Manifold. This PR updates the CeresManifoldFunctor to match the new expected interface for the ceres::Manifold.
Ubuntu 24.04 seems to require Ceres to be updated to v2.2.0 when building Ceres from source.
Edit:
Closes #288
Closes #290
Closes #296