React Native Upgrade for 0.59 #1553

orta · 2019-03-21T17:54:03Z

OK, now that #1551 is in.

Notable upgrade points:

Jest 0.23 -> 0.24
- Config changes
React Native 0.57 - 0.59
- Removal of NavigationiOS - See Adds the root license, and adds a Podspec michaelknoch/react-native-navigator-ios#1
  Adds the TS types to the repo michaelknoch/react-native-navigator-ios#2
- https://github.com/react-native-community/react-native-async-storage is next up on the chopping block, but not this release
Types
- Seems to be some pretty fundamental type upgrades, because that's a lot of errors

Blocked on

#skip_new_tests

orta · 2019-03-22T11:16:21Z

Looks like since we started piping the TS output into tee - then fails don't matter, normally not a problem because Danger would run on it - but while this PR is a draft, Travis doesn't make pr-based CI runs, so no danger output it seems.

ashfurrow

So exciting!

ashfurrow · 2019-03-22T16:09:03Z

Example/Gemfile

@@ -9,8 +9,5 @@ gem 'cocoapods-check'
 # To manage our secret keys
 gem "cocoapods-keys"

-# To apply fixes to the React Native code
-gem 'cocoapods-fix-react-native'


orta · 2019-03-25T12:26:32Z

@alloy - I believe you have commits laying around for this

alloy · 2019-03-26T12:36:33Z

Yup, continuing on this today 👍

orta · 2019-04-02T11:52:29Z

I made sure that TypeScript can fail CI now 👍

alloy · 2019-04-02T11:56:14Z

Thanks!

alloy · 2019-04-02T16:09:15Z

This PR updates tipsi-stripe from 5.2.4 to 7.4.0 because of RN API changes that were fixed in 7.2.0. Here’s the CHANGELOG https://github.com/tipsi/tipsi-stripe/blob/master/CHANGELOG.md#530---2018-07-23

We can probably fix the issue with a patch-package patch, if this update is deemed too dangerous.

Who is the person that knows most about how this should all work?

alloy · 2019-04-02T16:27:23Z

There’s a few deprecation warnings about libraries that have moved out of core RN, but I didn’t want to pile that on in this PR, we should follow up with that.

AsyncStorage
ViewPagerAndroid (not sure why we’re getting messages about this one)

orta · 2019-04-02T16:44:53Z

I just realized, we should be bumping major versions with these react native updates

alloy · 2019-04-02T16:58:05Z

Should we? Are we changing Emission’s API?

alloy · 2019-04-02T17:17:58Z

UPDATE: Fixed

~~Seeing the following error in some of the Consignment Flow forms.~~

alloy · 2019-04-02T17:29:11Z

@orta Ok, I believe you and @sweir27 are testing the tipsi-stripe upgrade, but otherwise I think this is good to go.

orta · 2019-04-02T17:37:20Z

I mean, yeah, it's a full breaking change the emission API right? You can't use this with an existing client at all

orta · 2019-04-02T17:37:52Z

patches/graphql+0.13.2.patch

@@ -10,7 +10,7 @@ patch-package
 -  }
 +  // if (name.length > 1 && name[0] === '_' && name[1] === '_') {
 +  //   return new _GraphQLError.GraphQLError('Name "' + name + '" must not begin with "__", which is reserved by ' + 'GraphQL introspection.', node);
-+  // }
+  // }x


alloy · 2019-04-02T17:42:21Z

I’m not sure I follow. Eigen doesn’t need to change any API usage (of Emission), right?

DangerCI · 2019-04-02T17:48:58Z

	Warnings
⚠️	Missing Test Files: `src/lib/Components/Bidding/Components/__tests__/BackButton-tests.tsx` `src/lib/Components/__tests__/DottedLine-tests.tsx` `src/lib/Components/__tests__/LoadFailureView-tests.tsx` `src/lib/Components/__tests__/OpaqueImageView-tests.tsx` `src/lib/Components/__tests__/Spinner-tests.tsx` `src/lib/Components/__tests__/SwitchView-tests.tsx` `src/lib/Components/__tests__/Video-tests.tsx` If these files are supposed to not exist, please update your PR body to include "#skip_new_tests".

Generated by 🚫 dangerJS

orta · 2019-04-09T19:09:42Z

OK, I've given the stripe code a runtime audit and everything looks to be working just fine. Merging!

orta · 2019-04-09T19:11:30Z

Thanks for putting the time in @alloy !

ashfurrow reviewed Mar 22, 2019

View reviewed changes

ashfurrow mentioned this pull request Mar 22, 2019

LD-531 - Adds correct margin/padding to last carousel image #1556

Merged

orta mentioned this pull request Mar 29, 2019

Comments: React Native, 3 years later artsy/artsy.github.io#521

Open

orta force-pushed the one_rn_60_ branch from d8ecdd7 to c8d65f9 Compare April 2, 2019 11:22

artsy deleted a comment from peril-staging bot Apr 2, 2019

alloy force-pushed the one_rn_60_ branch from c8d65f9 to b19e00a Compare April 2, 2019 13:10

orta marked this pull request as ready for review April 2, 2019 13:27

alloy assigned orta Apr 2, 2019

artsy deleted a comment from peril-staging bot Apr 2, 2019

artsy deleted a comment from DangerCI Apr 2, 2019

artsy deleted a comment from peril-staging bot Apr 2, 2019

orta commented Apr 2, 2019

View reviewed changes

alloy force-pushed the one_rn_60_ branch from e59bccf to 2c5e3dc Compare April 2, 2019 17:43

artsy deleted a comment from DangerCI Apr 2, 2019

alloy mentioned this pull request Apr 3, 2019

Missing tests #1573

Merged

alloy force-pushed the one_rn_60_ branch from 2c5e3dc to 96f2176 Compare April 3, 2019 11:00

orta and others added 11 commits April 9, 2019 16:52

[rn upgrade] Update the version to 0.59, add react-native-navigator-ios

733f7c4

[rn upgrade] Update CocoaPods, and remove the fixer cp plugin

75ace65

[rn upgrade] Convert to use the new NavigationiOS repo instead

cb0c4c1

[tsc] Make type checking green.

5cc5882

[test] Make green after rebase.

17b3d9d

[package] Bump tipsi-stripe to fix RN compat

d902963

[test] Disable flakey test.

c4d3fee

[test] Remove noise

b40ff10

[CHANGELOG] Document RN upgrade

a8835b8

[Consignment] Check if optional functions exist.

12fc9f9

[test] Change pending (which is really just disabled) to todo.

2601468

alloy force-pushed the one_rn_60_ branch from 96f2176 to 2601468 Compare April 9, 2019 15:20

orta merged commit 843d0ee into master Apr 9, 2019

alloy deleted the one_rn_60_ branch April 10, 2019 11:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

React Native Upgrade for 0.59 #1553

React Native Upgrade for 0.59 #1553

orta commented Mar 21, 2019 •

edited by alloy

Loading

orta commented Mar 22, 2019

ashfurrow left a comment

ashfurrow Mar 22, 2019

orta commented Mar 25, 2019

alloy commented Mar 26, 2019

orta commented Apr 2, 2019

alloy commented Apr 2, 2019

alloy commented Apr 2, 2019

alloy commented Apr 2, 2019 •

edited

Loading

orta commented Apr 2, 2019

alloy commented Apr 2, 2019

alloy commented Apr 2, 2019 •

edited

Loading

alloy commented Apr 2, 2019

orta commented Apr 2, 2019

orta Apr 2, 2019

alloy Apr 2, 2019

alloy commented Apr 2, 2019

DangerCI commented Apr 2, 2019

orta commented Apr 9, 2019

orta commented Apr 9, 2019

React Native Upgrade for 0.59 #1553

React Native Upgrade for 0.59 #1553

Conversation

orta commented Mar 21, 2019 • edited by alloy Loading

Blocked on

orta commented Mar 22, 2019

ashfurrow left a comment

Choose a reason for hiding this comment

ashfurrow Mar 22, 2019

Choose a reason for hiding this comment

orta commented Mar 25, 2019

alloy commented Mar 26, 2019

orta commented Apr 2, 2019

alloy commented Apr 2, 2019

alloy commented Apr 2, 2019

alloy commented Apr 2, 2019 • edited Loading

orta commented Apr 2, 2019

alloy commented Apr 2, 2019

alloy commented Apr 2, 2019 • edited Loading

alloy commented Apr 2, 2019

orta commented Apr 2, 2019

orta Apr 2, 2019

Choose a reason for hiding this comment

alloy Apr 2, 2019

Choose a reason for hiding this comment

alloy commented Apr 2, 2019

DangerCI commented Apr 2, 2019

orta commented Apr 9, 2019

orta commented Apr 9, 2019

orta commented Mar 21, 2019 •

edited by alloy

Loading

alloy commented Apr 2, 2019 •

edited

Loading

alloy commented Apr 2, 2019 •

edited

Loading