feature: Upload to S3 as Package #6851
Merged
+722
−607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyAghion
approved these changes
Dec 23, 2020
Convert the uploadToS3 script to its own package allowing us to remove its depdendencies from force. Addtionally, this removes the need to manage graceful-fs specially in force because of s3's dependencies on an outdated version.
icirellik
force-pushed
the
feature-upload-to-s3-package
branch
from
40eaf9a to
a0af543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the
uploadToS3.jsscript to its own package allowing us to removeits dependencies from
force. Additionally, this removes the need tomanage
graceful-fsin force because of s3's dependency on anoutdated version.