Check pixbuf loader signals #76
Conversation
This test will detect the problem noted in aruiz#73.
tests/t_signals.c
Outdated
| g_error ("%s", error->message); | ||
| g_assert (error == NULL); | ||
|
|
||
| g_free(pixbuf_data); |
There was a problem hiding this comment.
Please use g_clear_pointer to set pixbuf_data to NULL
tests/t_signals.c
Outdated
| g_error ("%s", error->message); | ||
| g_assert (error == NULL); | ||
|
|
||
| g_object_unref(G_OBJECT(loader)); |
tests/t_signals.c
Outdated
|
|
||
| g_object_unref(G_OBJECT(loader)); | ||
|
|
||
| g_strfreev (env); |
tests/t_signals.c
Outdated
| @@ -0,0 +1,83 @@ | |||
| #include <gdk-pixbuf/gdk-pixbuf.h> | |||
|
|
|||
| gint area_prepared_cb_count = 0; | |||
There was a problem hiding this comment.
Please decleare a struct with these members, create a static instance in the main function and pass it as data to the callbacks.
| GError *error = NULL; | ||
| gsize pixbuf_size; | ||
| guchar *pixbuf_data; | ||
| SignalsCounters *counters = g_new0(SignalsCounters, 1); |
There was a problem hiding this comment.
You can actually do SignalsCounter counters = { 0 }; and then pass it as &counters. No need to allocate from the heap.
| g_assert_cmpint (counters->closed_cb_count, ==, 1); | ||
| g_assert_cmpint (counters->size_prepared_cb_count, ==, 1); | ||
|
|
||
| g_clear_pointer(&counters, g_free); |
There was a problem hiding this comment.
As we use counters on the stack we don't need to free it anymore so we need to drop this line.
| main (gint argc, gchar **argv) | ||
| { | ||
| gchar **env = g_get_environ (); | ||
| GdkPixbufLoader *loader; |
There was a problem hiding this comment.
Not a big fan of uninitialized pointers, please call gdk_pixbuf_loader_new() here or just declare the variable down below, we can use modern C patterns here.
| GdkPixbufLoader *loader; | ||
| GError *error = NULL; | ||
| gsize pixbuf_size; | ||
| guchar *pixbuf_data; |
|
I ammended this myself and pushed it to mainline. Thanks for working on this! |
This test will detect the problem noted in #73.