Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB version option to mup.json #1023

Open
wants to merge 9 commits into
base: mupx
Choose a base branch
from
Open

MongoDB version option to mup.json #1023

wants to merge 9 commits into from

Conversation

jykae
Copy link

@jykae jykae commented May 20, 2016

Proposed changes

  • add mup.json "mongoVersion" option to select MongoDB version to be installed

@arunoda please review, this would help to choose sysadmin to choose compatible DB version, MDG does not have yet driver for latest 3.2

Thanks for awesome tool for Meteor deployments!

@MasterJames
Copy link

mongoVersion is great but I instictivly feel the default should reference latest or current (which ever is correct/works).
Of course for the new version at kadirahq if it's not already included there.
Changing to mupd ! ? Doubtful that's what they want there but maybe that makes sense. Oh wait it's not a daemon so I would disagree with that name change. It's back to mup there.

@jykae
Copy link
Author

jykae commented May 22, 2016

Yeah, wasn't sure what could be good default, latest or would it be good to throw error and ask user to check and define it?

These 3 commits should have been only for my own fork, sorry about that. I will cleanup this mess..
Name change helps distinct the tools, we have mup in use on 1 server, mupx is used mostly, and mupd to separate my own version.

Basically in this PR I propose only to have mongoVersion option, for situations when Mongo releases new breaking changes and Meteor is not yet ready for that.

@MasterJames
Copy link

Well yes mine I called mupz. I would do it in the new kadirahq version because there's no point to add PRs to a depreciated version that the devs basically don't monitor. I just take the time to break the bad news to people so you'really not left wondering and waiting.
They want and love community support and help with these kind of useful ideas, but of course ask there and see first if there isn't already a way or see if there's another plan that needs consideration.
It's of course getting harder for this meteor 1.2 focused version to meet the modern changing needs of meteor 1.3+ and beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants