ADSECGH-92 coverage for AdSecProfiles.cs

[DominikaLos]

No description provided.

[psarras]

simplify asserts

    private IProfile[] profiles = {
      GetAPerimeterProfile(),
      GetARectangleProfile()
    };

    [Fact]
    public void CheckProfiles_NotNull() {
      foreach (var profile in profiles) {
        var result = AdSecProfiles.CreateProfile(profile);
        Assert.NotNull(result);
      }
    }
    [Fact]
    public void CheckProfiles_HaveTheRightType() {
      foreach (var profile in profiles) {
        var result = AdSecProfiles.CreateProfile(profile);
        Assert.Equal($"I{profile.GetType().Name}_Implementation", result.GetType().Name);
      }
    }

    private static void NotNullAndRightType(Oasys.Profiles.IProfile result, IProfile profile) {
      Assert.NotNull(result);
      Assert.Equal($"I{profile.GetType().Name}_Implementation", result.GetType().Name);
    }

Simplify Gets

    private static SheetPileProfile GetASheetPileProfile() {
      var rotationInDegrees = new Angle(0, DefaultUnits.AngleUnit);

      var lengthOne = LengthOne();
      return new SheetPileProfile() {
        Rotation = rotationInDegrees,
        BottomFlangeWidth = lengthOne,
        FlangeThickness = lengthOne,
        Depth = lengthOne,
        TopFlangeWidth = lengthOne,
        WebThickness = lengthOne,
        Width = lengthOne,
      };
    }

    private static Length LengthOne() {
      return new Length(1, DefaultUnits.LengthUnitGeometry);
    }
~

• Rename the Method to "GetA"
• Adjust the Units to use the default Units
• Extract the Unit of One in a resulable method
• Reuse this one for all values, do not differentiate unless it crashes
• Move the class that has the "GetA" methods to another file, which we will be referencing on our tests whenever we need a profile.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.5%. Comparing base (3eac3c7) to head (0343ecd).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #123     +/-   ##
=======================================
+ Coverage   43.7%   44.5%   +0.8%     
=======================================
  Files         95      95             
  Lines       6656    6667     +11     
  Branches     867     869      +2     
=======================================
+ Hits        2912    2973     +61     
+ Misses      3665    3618     -47     
+ Partials      79      76      -3     

Files with missing lines	Coverage Δ
AdSecGH/Helpers/AdSecProfiles.cs	100.0% <100.0%> (+80.6%)	⬆️