Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADSECGH-59 Uprev AdSec API to v2.0.3 #93

Merged
merged 13 commits into from
Oct 23, 2024

Conversation

tlmnrnhrdt
Copy link
Contributor

No description provided.

@tlmnrnhrdt tlmnrnhrdt requested a review from DominikaLos March 28, 2024 07:18
DominikaLos
DominikaLos previously approved these changes Mar 29, 2024
# Conflicts:
#	AdSecGH/Components/2_Profile/CreateProfile.cs
#	AdSecGH/Helpers/AdSecInput.cs
#	AdSecGHTests/Components/1_Properties/CreateConcreteCrackCalculationParametersComponentTests.cs
#	AdSecGHTests/Parameters/AdSecSectionTests.cs
@SandeepArup SandeepArup changed the title ADSECGH-59-Uprev-AdSec-API-to-v2.0.1 ADSECGH-59: Uprev-AdSec-API-to-v2.0.1 Oct 21, 2024
@SandeepArup SandeepArup changed the title ADSECGH-59: Uprev-AdSec-API-to-v2.0.1 ADSECGH-59: Uprev AdSec API to v2.0.3 Oct 21, 2024
@psarras psarras changed the title ADSECGH-59: Uprev AdSec API to v2.0.3 ADSECGH-59 Uprev AdSec API to v2.0.3 Oct 22, 2024
@psarras psarras self-requested a review October 22, 2024 15:16
@psarras psarras requested a review from DominikaLos October 22, 2024 15:25
@SandeepArup SandeepArup merged commit d469781 into main Oct 23, 2024
4 of 5 checks passed
@SandeepArup SandeepArup deleted the task/ADSECGH-59-Uprev-AdSec-API-to-v2.0.1 branch October 23, 2024 07:10
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 9.37500% with 145 lines in your changes missing coverage. Please review.

Project coverage is 23.3%. Comparing base (fcdf31a) to head (8828cba).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
AdSecGH/Helpers/AdSecInput.cs 0.0% 81 Missing ⚠️
AdSecGH/Helpers/AdSecProfiles.cs 11.2% 54 Missing and 1 partial ⚠️
AdSecGH/Helpers/Result.cs 50.0% 7 Missing and 1 partial ⚠️
AdSecGH/Components/2_Profile/ProfileProperties.cs 0.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main     #93     +/-   ##
=======================================
+ Coverage   23.1%   23.3%   +0.1%     
=======================================
  Files         77      78      +1     
  Lines       6197    6219     +22     
  Branches     811     819      +8     
=======================================
+ Hits        1437    1452     +15     
- Misses      4729    4734      +5     
- Partials      31      33      +2     
Files with missing lines Coverage Δ
AdSecGH/AdSecGHInfo.cs 44.4% <ø> (ø)
AdSecGH/Components/2_Profile/CreateProfile.cs 30.6% <ø> (ø)
AdSecGH/Components/2_Profile/ProfileProperties.cs 42.1% <0.0%> (ø)
AdSecGH/Helpers/Result.cs 20.0% <50.0%> (+20.0%) ⬆️
AdSecGH/Helpers/AdSecProfiles.cs 11.2% <11.2%> (ø)
AdSecGH/Helpers/AdSecInput.cs 0.0% <0.0%> (ø)

@DominikaLos DominikaLos restored the task/ADSECGH-59-Uprev-AdSec-API-to-v2.0.1 branch October 23, 2024 07:27
@DominikaLos DominikaLos deleted the task/ADSECGH-59-Uprev-AdSec-API-to-v2.0.1 branch October 23, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants