Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdSecGH-65 Business Logic Separation #99

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

psarras
Copy link
Collaborator

@psarras psarras commented Oct 28, 2024

No description provided.

@psarras psarras changed the title ADSECGH-65 Business Logic Separation ADSecGH-65 Business Logic Separation Oct 29, 2024
@psarras psarras changed the title ADSecGH-65 Business Logic Separation AdSecGH-65 Business Logic Separation Oct 31, 2024
@psarras psarras requested a review from SandeepArup November 20, 2024 10:55
@psarras psarras marked this pull request as ready for review November 20, 2024 14:18
@psarras psarras merged commit e06414e into main Nov 21, 2024
7 checks passed
@psarras psarras deleted the task/ADSECGH-65-Business-Logic branch November 21, 2024 12:18
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 27.50000% with 29 lines in your changes missing coverage. Please review.

Project coverage is 23.3%. Comparing base (e4896ef) to head (1d86d5f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
AdSecCore/Result.cs 0.0% 24 Missing ⚠️
AdSecCore/DoubleComparer.cs 68.7% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #99   +/-   ##
=====================================
  Coverage   23.3%   23.3%           
=====================================
  Files         78      79    +1     
  Lines       6219    6219           
  Branches     819     819           
=====================================
+ Hits        1452    1455    +3     
+ Misses      4734    4731    -3     
  Partials      33      33           
Files with missing lines Coverage Δ
AdSecCore/DoubleComparer.cs 68.7% <68.7%> (ø)
AdSecCore/Result.cs 0.0% <0.0%> (ø)
---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants