check settings_pack::max_out_request_queue before alert outstanding_r…

[tkittich]

…equest_limit_reached

This should fix performance warning: max outstanding piece requests reached, outstanding_request_limit_reached

[arvidn]

The existing check compares against m_max_out_request_queue which is set to this setting, here:

m_max_out_request_queue(aux::clamp_assign<std::uint16_t(m_settings.get_int(settings_pack::max_out_request_queue)))

This limit can be adjusted if the peer indicates a reqq limit in the extended handshake, or if the peer is snubbed (or if the peer is identified as bitcomet).

So, I think you're right to check against the setting instead. I think the existing check can be removed however.

[arvidn]

If you take my suggestion, please add a note to the Changelog as well, that this issue was addressed.

[tkittich]

If you take my suggestion, please add a note to the Changelog as well, that this issue was addressed.

Thank you for the review & suggestions.