Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix publish to pypi #7836

Merged
merged 1 commit into from
Jan 29, 2025
Merged

fix publish to pypi #7836

merged 1 commit into from
Jan 29, 2025

Conversation

arvidn
Copy link
Owner

@arvidn arvidn commented Jan 28, 2025

No description provided.

@arvidn arvidn mentioned this pull request Jan 28, 2025
Merged
@arvidn arvidn force-pushed the fix-pypi branch 3 times, most recently from 40076e4 to c151ccc Compare January 29, 2025 00:15
@arvidn
Copy link
Owner Author

arvidn commented Jan 29, 2025

@qstokkink @xavier2k6 this looks like it works. Does it look reasonable to you?

@qstokkink
Copy link

Seems ok. 👍

@xavier2k6
Copy link
Contributor

The very last line of upload_pypi_test can be changed from repository_url -> repository-url to remove deprecation waring.

@arvidn
Copy link
Owner Author

arvidn commented Jan 29, 2025

The very last line of upload_pypi_test can be changed from repository_url -> repository-url to remove deprecation waring.

Thanks. I'll leave that for a later PR

@arvidn arvidn merged commit 5b09ff8 into RC_2_0 Jan 29, 2025
102 checks passed
@arvidn arvidn deleted the fix-pypi branch January 29, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arvidn @qstokkink @xavier2k6