Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use DataTree from xarray instead of from xarray-datatree #24

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Oct 15, 2024

related to #14. I wouldn't merge just yet, and instead merge as many PRs as possible,
create similar PRs in arviz-stats and arviz-plots to pull the band aid.


📚 Documentation preview 📚: https://arviz-base--24.org.readthedocs.build/en/24/

Copy link
Contributor

@amaloney amaloney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I would not merge this to main though, since it has breaking changes. Let's make a "0.3.0" branch and merge to that. Then we can sync with the other packages using the 0.3.0 branch to fix problems. For each project, we should make a "0.3.0" branch as well, and any fixes that go into them using this branch, should be merged into their respective 0.3.0 branches. Once all bugs have been ironed out, we can push each 0.3.0 branch into main, tag, and then release.

@OriolAbril
Copy link
Member Author

I was thinking about making a 0.3 release before merging, then using 0.4.0.dev0 as version on main and merging this. But at this stage I would not worry too much about releases nor breaking changes. For arviz-devs/arviz-stats#16 for example my idea was also to directly do the change in arviz-stats, update arviz-plots as needed and consider it done, no warnings or duplication of dim/dims

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants