Parse string bool values in CmdStan csv header #2354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahartikainen
changed the title
NicholasCowie
suggested changes
Jun 18, 2024
arviz/data/io_cmdstan.py
Outdated
| @@ -746,6 +747,9 @@ def _process_configuration(comments): | |||
| elif match_float: | |||
| key, value = match_float.group(1), match_float.group(2) | |||
| results[key] = float(value) | |||
| elif match_str_bool: | |||
| key, value = match_str_bool.group(1), match_str_bool(2) | |||
There was a problem hiding this comment.
match_str_bool(2) I believe should be matr_str_bool.group(2)
There was a problem hiding this comment.
Additionally, because the results dictionary values are converted to strings the value False is read incorrectly as "False" when attempting to convert to an integer on line 807 of this PR int(pconf.get("save_warmup", 0))
There was a problem hiding this comment.
Good catch, let's just turn these to int
NicholasCowie
approved these changes
Jun 18, 2024
|
I will merge this one in, given that CI errors are not related to changes done in here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2353
Description
Parse string bool values in CmdStan csv header.
Checklist
📚 Documentation preview 📚: https://arviz--2354.org.readthedocs.build/en/2354/