Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose new features as preview submodule #2361

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

OriolAbril
Copy link
Member

@OriolAbril OriolAbril commented Jul 19, 2024

Description

Checklist

  • Does the PR follow official PR format?
  • Does the PR include new or updated tests to cover the new feature (using pytest fixture pattern)? No, I tested locally.
  • Is the code style correct (follows pylint and black guidelines)?
  • Is the new feature listed in the New features section of the changelog?

📚 Documentation preview 📚: https://arviz--2361.org.readthedocs.build/en/2361/

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (2bd2570) to head (ab5acd8).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
+ Coverage   87.00%   87.01%   +0.01%     
==========================================
  Files         123      124       +1     
  Lines       12775    12788      +13     
==========================================
+ Hits        11115    11128      +13     
  Misses       1660     1660              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ahartikainen ahartikainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@OriolAbril OriolAbril merged commit 1401a06 into main Jul 19, 2024
12 checks passed
@OriolAbril OriolAbril deleted the submodule_preview branch July 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants