Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename predictive_sliders to predictive_explorer refactor and new features #292

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

aloctavodia
Copy link
Contributor

  • This renames the predictive_slider function to predictive_explorer, as we no longer use sliders but float or int boxes. This makes it easier to explore a wider range of values without PreliZ having to guess a good default range. The alternative could be to add boxes to set the minimum and maximum values of sliders, but that will be a more complex interface with little gain for users.

  • This also adds a resample button, so users can explore how the prior predictive distribution changes even without changing any parameter. This adds the option to set the values of x_lim for the plot.

  • This also changes the default to ecdf (empirical cdf) instead of KDE

Figure 1

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #292 (beafa01) into main (90cfe15) will increase coverage by 0.06%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main     #292      +/-   ##
==========================================
+ Coverage   82.43%   82.49%   +0.06%     
==========================================
  Files          32       32              
  Lines        3906     3937      +31     
==========================================
+ Hits         3220     3248      +28     
- Misses        686      689       +3     
Files Coverage Δ
preliz/internal/parser.py 63.01% <100.00%> (ø)
preliz/predictive/__init__.py 100.00% <100.00%> (ø)
preliz/predictive/predictive_explorer.py 85.00% <100.00%> (ø)
preliz/tests/test_predictive_explorer.py 100.00% <100.00%> (ø)
preliz/internal/plot_helper.py 72.36% <90.62%> (+1.19%) ⬆️

@aloctavodia aloctavodia merged commit d0f0cfb into arviz-devs:main Oct 24, 2023
4 checks passed
@aloctavodia aloctavodia deleted the pred_explorer branch October 24, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants