Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add faster Normal implementation #344

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

aloctavodia
Copy link
Contributor

@aloctavodia aloctavodia commented Mar 7, 2024

Distributions in PreliZ are wrappers around SciPy distributions. This is fine for many situations, but when iterative operations are required like in optimization we could benefit from faster implementations.

This could also be used to avoid duplication of code and efforts, for instance in Kulprit we also need fast logpdf evaluations.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 88.39779% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 86.25%. Comparing base (f0a63bc) to head (9fc1336).

Files Patch % Lines
preliz/distributions/normal.py 85.36% 12 Missing ⚠️
preliz/distributions/distributions.py 86.04% 6 Missing ⚠️
preliz/internal/distribution_helper.py 77.77% 2 Missing ⚠️
preliz/tests/test_dist_scipy.py 97.14% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   86.70%   86.25%   -0.45%     
==========================================
  Files          38       40       +2     
  Lines        4303     4425     +122     
==========================================
+ Hits         3731     3817      +86     
- Misses        572      608      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aloctavodia aloctavodia merged commit b2732e5 into arviz-devs:main Mar 7, 2024
4 checks passed
@aloctavodia aloctavodia deleted the fast_d branch March 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants