Remove the is_constructible check because it breaks the usecase with …

…forward declared types
arximboldi · Mar 12, 2024 · c29e7ff · c29e7ff
1 parent 9121da5
commit c29e7ff
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/immer/box.hpp b/immer/box.hpp
@@ -74,8 +74,7 @@ class box
      */
     template <typename Arg,
               typename Enable = std::enable_if_t<
-                  !std::is_same<box, std::decay_t<Arg>>::value &&
-                  std::is_constructible<T, Arg>::value>>
+                  !std::is_same<box, std::decay_t<Arg>>::value>>
     box(Arg&& arg)
         : impl_{detail::make<heap, holder>(std::forward<Arg>(arg))}
     {}

diff --git a/test/extra/archive/test_box.cpp b/test/extra/archive/test_box.cpp
@@ -88,3 +88,21 @@ TEST_CASE("Test saving and mutating a box")
     const auto loaded2 = loader.load(id2);
     REQUIRE(loaded2.get() == "hello world");
 }
+
+namespace {
+struct fwd_type;
+struct test_type
+{
+    immer::box<fwd_type> data;
+};
+struct fwd_type
+{
+    int data = 123;
+};
+} // namespace
+
+TEST_CASE("Test box with a fwd declared type")
+{
+    auto val = test_type{};
+    REQUIRE(val.data.get().data == 123);
+}