Switch away from doctest, and drop it #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the only test using doctest, so switch it to catch2 like all the other tests. The only change needed was to switch from SUBCASE() to SECTION(); the test works fine also after the switch.
There are no more tests using doctest now; hence, drop the old copy of it, and its related build system bits.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #266 +/- ##
=======================================
Coverage 90.53% 90.53%
=======================================
Files 119 119
Lines 12144 12144
=======================================
Hits 10994 10994
Misses 1150 1150
|
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one test using doctest instead of catch2; hence, switch it to catch2, so doctest can be dropped.
This is also prompted by the fact that the old doctest copy does not build with glibc 2.34 (released 2 years ago [1]), because
SIGSTKSZis no more a constant; this was fixed long ago in doctest upstream [2][3]. Since we can get away from doctest, let's get rid of it rather than patching/updating an old copy.[1] https://sourceware.org/pipermail/libc-alpha/2021-August/129718.html
[2] doctest/doctest#473
[3] doctest/doctest@099d541