Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix finding cursesw #191

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

pinotree
Copy link
Contributor

@pinotree pinotree commented Aug 3, 2023

The right variable for requesting the unicode version of curses is CURSES_NEED_WIDE, not CMAKE_CURSES_NEED_WIDE [1].

[1] https://cmake.org/cmake/help/latest/module/FindCurses.html

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #191 (1e3f0f5) into master (69ab331) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##           master     #191   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          81       81           
  Lines        2875     2875           
=======================================
  Hits         2725     2725           
  Misses        150      150           

The right variable for requesting the unicode version of curses is
CURSES_NEED_WIDE, not CMAKE_CURSES_NEED_WIDE [1].

[1] https://cmake.org/cmake/help/latest/module/FindCurses.html
@pinotree pinotree changed the title cmake: find finding cursesw cmake: fix finding cursesw Aug 3, 2023
@arximboldi
Copy link
Owner

Oh, thank you!

@arximboldi arximboldi merged commit 31ed033 into arximboldi:master Aug 7, 2023
7 checks passed
@pinotree pinotree deleted the cmake-fix-find-curses branch August 7, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants