Merge pull request #41 from od0/patch/pageheight

Removing adjustment for parentOffsetTop which can cause issues with both the scollbar container size and the calculated scroll length
asafdav · Jun 19, 2015 · 2bc478c · 2bc478c
2 parents a124f5c + 3a1ad43
commit 2bc478c
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/src/ng-scrollbar.js b/src/ng-scrollbar.js
@@ -161,9 +161,6 @@ angular.module('ngScrollbar', []).directive('ngScrollbar', [
 
         var buildScrollbar = function (rollToBottom) {
 
-          // Getting top position of a parent element to place scroll correctly
-          var parentOffsetTop = element[0].parentElement.offsetTop;
-
           rollToBottom = flags.bottom || rollToBottom;
           mainElm = angular.element(element.children()[0]);
           transculdedContainer = angular.element(mainElm.children()[0]);
@@ -172,11 +169,7 @@ angular.module('ngScrollbar', []).directive('ngScrollbar', [
           thumbLine = angular.element(thumb.children()[0]);
           track = angular.element(angular.element(tools.children()[0]).children()[1]);
 
-          // Check if scroll bar is needed
-          page.height = element[0].offsetHeight - parentOffsetTop;
-          if (page.height < 0) {
-            page.height = element[0].offsetHeight;
-          }
+          page.height = element[0].offsetHeight;
           page.scrollHeight = transculdedContainer[0].scrollHeight;
 
           if (page.height < page.scrollHeight) {