Skip to content

Issues: asarturas/merchant-offer-service

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9 Open 0 Closed
9 Open 0 Closed
Author
Filter by author
Loading
Label
Filter by label
Loading
Use alt + click/return to exclude labels
or ⇧ + click/return for logical OR
Projects
Filter by project
Loading
Milestones
Filter by milestone
Loading
Assignee
Filter by who’s assigned
Sort
Sort by
Newest Oldest Most commented Least commented Recently updated Least recently updated Best match
Most reactions
👍 👎 😄 🎉 😕 ❤️ 🚀 👀

Issues list

Improve naming in domain (consistency)
#9 opened Oct 30, 2018 by asarturas
All dates are in UTC (but it does not explicitly say so in output)
#8 opened Oct 30, 2018 by asarturas
Offer validity range is limited to integer days
#7 opened Oct 30, 2018 by asarturas
Offer currency is hardcoded and BigDecimal is used instead of just using currency
#6 opened Oct 30, 2018 by asarturas
Matching product offers could be ordered by expiration date
#5 opened Oct 30, 2018 by asarturas
There is no cleanup of expired offers and no way for consumers to see expired offers
#4 opened Oct 30, 2018 by asarturas
The service is hardcoded to IO, could be generalised
#3 opened Oct 30, 2018 by asarturas
The end to end test is very minimal
#2 opened Oct 30, 2018 by asarturas
CI setup is missing
#1 opened Oct 30, 2018 by asarturas
ProTip! Type g p on any issue or pull request to go back to the pull request listing page.