Update php.dockerfile #221
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added necessary PHP extensions and their dependencies
Gildus
reviewed
Jan 8, 2025
| # RUN docker-php-ext-install pdo pdo_mysql | ||
|
|
||
| # Install Redis extension manually | ||
| RUN mkdir -p /usr/src/php/ext/redis \ |
There was a problem hiding this comment.
This code would no longer work, because the extension would already be installed with:
RUN pecl install redis...
Gildus
reviewed
Jan 8, 2025
| pcntl | ||
|
|
||
| # Install Redis extension | ||
| RUN pecl install redis && docker-php-ext-enable redis |
There was a problem hiding this comment.
It could be:
RUN pecl install igbinary && \
docker-php-ext-enable igbinary && \
echo "y" | pecl install redis && \
docker-php-ext-enable redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added necessary PHP extensions and their dependencies