-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-49: Implementation proposal for CI and CD #61
Conversation
Signed-off-by: Damien DUPORTAL <[email protected]>
Signed-off-by: Damien DUPORTAL <[email protected]>
…y for users Signed-off-by: Damien DUPORTAL <[email protected]>
Ping @mojavelinux @jirutka @mgreau for this (happy) new year 2018, I propose we enable fully the Travis CI on this repository to ensure feedback to contributors :) |
Signed-off-by: Damien DUPORTAL <[email protected]>
Thanks for working on it @dduportal |
@dduportal sorry I finally can't review it this week, I'll let you know when I'm ready to do it. |
@mgreau no problem. I pinged you for the bugfix which was affecting users. Thanks for the feedback. |
Signed-off-by: Damien DUPORTAL <[email protected]>
Hello @mgreau @mojavelinux , I would like to bump on this PR (I know both of you are busy but just in case) :) |
My aplogies @gscheibel , I just realized I totally forgot to add you as approver / mention you here. I owe you a beer/tea/coffee if you are at BreizhCamp or DevoxxFR. |
After discussing this with @mgreau at the DevoxxFR 2018, he agree on we merge this. Let's rollback or change if you have any issue! |
Let's do it! |
Do you still need any access that you don't currently have? |
Hello @mojavelinux ! If you do not mind, I would need access to the DockerHub 's asciidoctor image, so I'll be able to:
|
And again @mojavelinux , thanks for you trust! |
Of course! You should be all set now. |
Are any changes needed in the Travis settings? |
@mojavelinux sounds good, thanks a lot! |
This Pull Request is a proposal implementation for #49 .
IMPORTANT if this implementation of the deploy phase is fine, can someone with the right to the asciidoctor image on the DockerHub set up configuration or delegate to me the rights? The variable containing the token in https://travis-ci.org/asciidoctor/docker-asciidoctor/settings need to be adapted (as well as the curl destination in the deploy goal in this PR).
As side-kick setting, the
master
branch of this repository had been configured to be protected (need CI check).Ping @mojavelinux @mgreau , I would like your review and advise on this?