Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-49: Implementation proposal for CI and CD #61

Merged
merged 7 commits into from
Apr 21, 2018
Merged

GH-49: Implementation proposal for CI and CD #61

merged 7 commits into from
Apr 21, 2018

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 22, 2017

This Pull Request is a proposal implementation for #49 .

  • It features the use of Travis-CI to build and test the docker-asciidoctor container
  • GNU Make is used to provide a workflow
  • Currently, the Deploy phase is proposed using my DockerHub account (https://hub.docker.com/r/dduportal/docker-asciidoctor/), to have a real life working example, with pushed images

IMPORTANT if this implementation of the deploy phase is fine, can someone with the right to the asciidoctor image on the DockerHub set up configuration or delegate to me the rights? The variable containing the token in https://travis-ci.org/asciidoctor/docker-asciidoctor/settings need to be adapted (as well as the curl destination in the deploy goal in this PR).

As side-kick setting, the master branch of this repository had been configured to be protected (need CI check).

Ping @mojavelinux @mgreau , I would like your review and advise on this?

Signed-off-by: Damien DUPORTAL <[email protected]>
@dduportal
Copy link
Contributor Author

Ping @mojavelinux @jirutka @mgreau for this (happy) new year 2018, I propose we enable fully the Travis CI on this repository to ensure feedback to contributors :)

Signed-off-by: Damien DUPORTAL <[email protected]>
@mgreau
Copy link
Member

mgreau commented Jan 3, 2018

Thanks for working on it @dduportal
I'll test it and get back to you this weekend (on mobile now)

@mgreau
Copy link
Member

mgreau commented Jan 10, 2018

I'll test it and get back to you this weekend (on mobile now)

@dduportal sorry I finally can't review it this week, I'll let you know when I'm ready to do it.

@dduportal
Copy link
Contributor Author

@mgreau no problem. I pinged you for the bugfix which was affecting users.
For this PR, time is needed to review it, so do not bother your self and do it when you'll have your mind free :)

Thanks for the feedback.

@dduportal
Copy link
Contributor Author

Hello @mgreau @mojavelinux , I would like to bump on this PR (I know both of you are busy but just in case) :)

@dduportal dduportal requested a review from gscheibel March 16, 2018 10:23
@dduportal
Copy link
Contributor Author

My aplogies @gscheibel , I just realized I totally forgot to add you as approver / mention you here.

I owe you a beer/tea/coffee if you are at BreizhCamp or DevoxxFR.

@dduportal dduportal merged commit a5ec151 into asciidoctor:master Apr 21, 2018
@dduportal
Copy link
Contributor Author

After discussing this with @mgreau at the DevoxxFR 2018, he agree on we merge this.

Let's rollback or change if you have any issue!

@dduportal dduportal deleted the gh-49-ci branch April 21, 2018 10:57
@mojavelinux
Copy link
Member

Let's do it!

@mojavelinux
Copy link
Member

Do you still need any access that you don't currently have?

@dduportal
Copy link
Contributor Author

Hello @mojavelinux !

If you do not mind, I would need access to the DockerHub 's asciidoctor image, so I'll be able to:

@dduportal
Copy link
Contributor Author

And again @mojavelinux , thanks for you trust!

@mojavelinux
Copy link
Member

Of course! You should be all set now.

@mojavelinux
Copy link
Member

Are any changes needed in the Travis settings?

@dduportal
Copy link
Contributor Author

@mojavelinux sounds good, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants